Add FDT Dockerfile for FDT and FDT Agent#23
Open
fixy wants to merge 2 commits intocmscaltech:masterfrom
Open
Conversation
juztas
requested changes
Feb 12, 2024
Collaborator
juztas
left a comment
juztas
left a comment
There was a problem hiding this comment.
These 2 dirs are pretty much equal, only difference is:
CMD ["java", "-jar", "fdt.jar", "-p", "54321", "-autoport", "-portrange", "100", "-agent"]
vs
CMD ["java", "-jar", "fdt.jar", "-p", "54321"]
So I would add everything inside fdt/ directory and have 2 files:
Dockerfile-agent
Dockerfile
and github workflows can build one or another.
juztas
requested changes
Mar 11, 2024
| @@ -0,0 +1,87 @@ | |||
| name: Docker Image Build For FDT Agent | |||
Collaborator
There was a problem hiding this comment.
you might want to replace name. Same name will confuse github actions.
| @@ -0,0 +1,5 @@ | |||
| for did in `docker images | grep hepgui | awk '{print $3}' | uniq`; | |||
| @@ -0,0 +1,5 @@ | |||
| source ../environment | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.